phpstan-8 for category class #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
reviewed
May 30, 2023
app/Models/Category.php
Outdated
| /** @var array<FreshRSS_Feed>|null */ | ||
| /** @var array<FreshRSS_Feed> */ |
There was a problem hiding this comment.
I am not sure this is a good solution, as we need to test for nullability below: if ($this->feeds === null)
There was a problem hiding this comment.
got to matermost ?
There was a problem hiding this comment.
$feedDAO->listByCategory($this->id()); return always a array() of FreshRSS_Feed
There was a problem hiding this comment.
See below, line 109: if ($this->feeds === null)
Alkarex
reviewed
May 31, 2023
| * @throws Minz_ConfigurationNamespaceException | ||
| * @throws Minz_PDOConnectionException | ||
| */ | ||
|
|
||
| public function feeds(): array { | ||
| if ($this->feeds === null) { |
There was a problem hiding this comment.
This is the line testing for null
Alkarex
approved these changes
Jun 6, 2023
math-GH
pushed a commit
to math-GH/FreshRSS
that referenced
this pull request
Jul 4, 2023
* phpstan-8 for category class * Another approach to nullable FreshRSS#5434 (comment) --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Pull request checklist: