Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deep link to extension configuration #5449

Merged
merged 5 commits into from Jun 13, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Jun 9, 2023

Allow a full screen view of an extension configuration, with a deep-link URL.
Example:
image

Background: I have a use-case for which I need to provide a direct link to an extension configuration page.

@Alkarex Alkarex added UI 🎨 User Interfaces Extension 🔌 labels Jun 9, 2023
@Alkarex Alkarex added this to the 1.22.0 milestone Jun 9, 2023
@Alkarex
Copy link
Member Author

Alkarex commented Jun 9, 2023

For those working with extensions, could you please double-check that it does not break your use-cases?

@math-GH
Copy link
Contributor

math-GH commented Jun 9, 2023

There is a bug:

  1. go to extension config page
  2. open the settings of a extension, f.e. CustomCSS (the slider will be opened)
  3. save the settings

expected: the slider will be shown as slider or closed.
What is visible: The settings will be opened in full screen

@Alkarex
Copy link
Member Author

Alkarex commented Jun 11, 2023

What about now @math-GH ?

@math-GH
Copy link
Contributor

math-GH commented Jun 12, 2023

Additional question:
If you open the config in a new tab, than the new tab has no navigation on the left hand side. Is it on purpose?
Compared to the feed configuration, where the left navigation is given in a new tab

@Alkarex
Copy link
Member Author

Alkarex commented Jun 12, 2023

Additional question:
If you open the config in a new tab, than the new tab has no navigation on the left hand side. Is it on purpose?
Compared to the feed configuration, where the left navigation is given in a new tab

No, good point, it was not on purpose

@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

@math-GH Done d546aff

@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

Please double check: Does it make sense in the "full screen mode" (extension configs in new tab opened), that the config page will no be closed, when clicking the submit button?

@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

Does it make sense in the "full screen mode" (extension configs in new tab opened), that the config page will no be closed, when clicking the submit button?

Do you mean automatically closing the window/tab (if so, then no: in my case, it is the main window, not a new tab; and in other cases, I only think this should be done for modal windows, not tabs), or redirecting to another page after submission (if so, I do not really mind, but I find it fine as it is now)

@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

fine for me too

@Alkarex Alkarex merged commit 3fe68a3 into FreshRSS:edge Jun 13, 2023
1 check passed
@Alkarex Alkarex deleted the full-page-extension-configuration branch June 13, 2023 20:40
@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

@Alkarex I found one thing after it was merged: The <title> is just the default FreshRSS. It would be better to have the title of the extension in the tab.

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jun 14, 2023
And fix full-page view of category configuration.
FIx FreshRSS#5449 (comment)
@Alkarex Alkarex mentioned this pull request Jun 14, 2023
@Alkarex
Copy link
Member Author

Alkarex commented Jun 14, 2023

@Alkarex I found one thing after it was merged: The <title> is just the default FreshRSS. It would be better to have the title of the extension in the tab.

Done in #5469

Alkarex added a commit that referenced this pull request Jun 15, 2023
* Fix slider titles
And fix full-page view of category configuration.
FIx #5449 (comment)

* Fix user queries and user management
Implement #5469 (comment)
math-GH pushed a commit to math-GH/FreshRSS that referenced this pull request Jul 4, 2023
* Allow deep link to extension configuration
Full screen

* Support slider

* Add aside_configure
Fix FreshRSS#5449 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants