Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenID Connect crash on ARM #5463

Merged
merged 1 commit into from Jun 13, 2023
Merged

Fix OpenID Connect crash on ARM #5463

merged 1 commit into from Jun 13, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Jun 13, 2023

Only enable the Apache auth_openidc module when actually used
Fix #5460
Follow-up of #5351

Only enable the Apache auth_openidc module when actually used
Fix FreshRSS#5460
Follow-up of FreshRSS#5351
@Alkarex Alkarex added this to the 1.22.0 milestone Jun 13, 2023
@Alkarex Alkarex added Security 🛡️ Bug (confirmed) 🐞 issues that are reproducable labels Jun 13, 2023
@Alkarex Alkarex mentioned this pull request Jun 13, 2023
6 tasks
@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

Ping @aaronschif

@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

auth_openidc still seems to make Apache crash at start, but at least Apache works when OIDC_ENABLED is not set

@Alkarex Alkarex merged commit ae8dfc1 into FreshRSS:edge Jun 13, 2023
1 check passed
@Alkarex Alkarex deleted the openidc-arm branch June 13, 2023 14:28
@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

Upstream bug / discussion: OpenIDC/mod_auth_openidc#1067

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jun 13, 2023
Quiet output for a2enmod, a2dismod, a2disconf, a2dissite, a2ensite to avoid many messages the following, which are not even relevant because Apache is not yet started at this stage:

```
To activate the new configuration, you need to run:
  systemctl restart apache2
```

Related to FreshRSS#5463
@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

@aaronschif If you can try our freshly patched Docker images, that would be nice.

@Alkarex Alkarex added the Docker Everything related to Docker label Jun 13, 2023
Alkarex added a commit that referenced this pull request Jun 14, 2023
Quiet output for a2enmod, a2dismod, a2disconf, a2dissite, a2ensite to avoid many messages the following, which are not even relevant because Apache is not yet started at this stage:

```
To activate the new configuration, you need to run:
  systemctl restart apache2
```

Related to #5463
math-GH pushed a commit to math-GH/FreshRSS that referenced this pull request Jul 4, 2023
Only enable the Apache auth_openidc module when actually used
Fix FreshRSS#5460
Follow-up of FreshRSS#5351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (confirmed) 🐞 issues that are reproducable Docker Everything related to Docker Security 🛡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] docker status Restarting (135)
1 participant