Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS feed title meta-click behavior #5492

Merged
merged 2 commits into from Jun 24, 2023

Conversation

kemayo
Copy link
Contributor

@kemayo kemayo commented Jun 24, 2023

Changes proposed in this pull request:

  • On macOS, command-clicking the feed item's title should open the URL in a new tab, just as ctrl-clicking them on another OS would

How to test the feature manually:

  1. Using macOS, command-click the link in a feed item's title
  2. Using another OS, verify that this hasn't interfered with ctrl-clicking the feed item's title

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
    -- Pure JS change, not unit-testable without major additions to the project
  • documentation updated
    -- No documentation affected, but I did update the relevant comment in the JS file...

In macOS command-click is used for open-in-new-tab, not ctrl-click.
@Alkarex Alkarex added this to the 1.22.0 milestone Jun 24, 2023
@Alkarex Alkarex added Shortcuts UI 🎨 User Interfaces labels Jun 24, 2023
@Alkarex Alkarex merged commit 6999407 into FreshRSS:edge Jun 24, 2023
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Jun 24, 2023

Welcome and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shortcuts UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants