fix many "Only booleans are allowed in an if condition"

[ColonelMoutarde]

Changes proposed in this pull request:

• By resetting the "booleansInConditions" directive to true, 370 errors are detected. I've corrected 20 of the errors that phpstan is reporting. There are still many...

Pull request checklist:

• clear commit messages
• code manually tested

[Alkarex]

What happened here? This looks quite wrong

[ColonelMoutarde]

if I don't do this phpstan returns an error because $ex is unknown at this point

[Alkarex]

I have reverted without problem, as far as I can see. But the point was that the logic was broken with your changes.

[Alkarex]

I have fixed several regressions and other smaller details

[Alkarex]

Let's not hurry making more changes of this type, especially because I believe that it leads to less readable and more error-prone code in many situations, for instance the calls to preg_grep(), preg_match(). Indeed, this original PR had several regressions, which I am guessing were at least partially due to the more complicated / less readable syntax.
I think we should relax the booleansInConditions rule to accept { 0, 1 } (and maybe null) in addition of { true, false }.
phpstan/phpstan-strict-rules#221

[ColonelMoutarde]

Let's not hurry making more changes of this type, especially because I believe that it leads to less readable and more error-prone code in many situations, for instance the calls to preg_grep(), preg_match(). Indeed, this original PR had several regressions, which I am guessing were at least partially due to the more complicated / less readable syntax. I think we should relax the booleansInConditions rule to accept { 0, 1 } (and maybe null) in addition of { true, false }. phpstan/phpstan-strict-rules#221

hello, the problem is polymorphism. it must be reduced as much as possible. a function must return only one type.

See :
https://www.phptutorial.net/php-oop/php-polymorphism/

if a native php function is polymorphic (for historical reasons), the best thing to do is to create a method that encapsulates and returns only what is necessary.