New extension hook entry_auto_read #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For extensions to be notified of articles being automatically marked as read for various reasons
lib/Minz/ExtensionManager.php
Outdated
Comment on lines
29
to
32
| 'entry_auto_read' => array( // function(FreshRSS_Entry $entry, string $why) -> none | ||
| 'list' => array(), | ||
| 'signature' => 'PassArguments', | ||
| ), |
There was a problem hiding this comment.
use [] for arrays ;)
There was a problem hiding this comment.
Another time, not to mess the rest of the PR here
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Aug 3, 2023
Partial revert of FreshRSS#5505 We should not apply the auto mark as read rule based on existing titles for updated articles, because the match would most of the time be on that same article's title.
Alkarex
commented
Aug 3, 2023
Comment on lines
+488
to
+491
| $entry->applyFilterActions($titlesAsRead); | ||
| if ($readWhenSameTitleInFeed > 0) { | ||
| $titlesAsRead[$entry->title()] = true; | ||
| } |
There was a problem hiding this comment.
This was wrong. Reverted in #5561
Alkarex
added a commit
that referenced
this pull request
Aug 3, 2023
Partial revert of #5505 We should not apply the auto mark as read rule based on existing titles for updated articles, because the match would most of the time be on that same article's title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extensions to be notified of articles being automatically marked as read for various reasons