Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sharing via clipboard for no https/localhost environments #5606

Merged
merged 5 commits into from Aug 29, 2023
Merged

Fix: sharing via clipboard for no https/localhost environments #5606

merged 5 commits into from Aug 29, 2023

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Aug 22, 2023

Closes #5595

Changes proposed in this pull request:

  • add a fallback if environment is not https or localhost

How to test the feature manually:

use the sharing option "Clipboard" ousite of https or localhost environment

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added this to the 1.22.0 milestone Aug 22, 2023
@math-GH math-GH mentioned this pull request Aug 22, 2023
Closed
@Alkarex Alkarex added the UI 🎨 User Interfaces label Aug 22, 2023
Frenzie
Frenzie approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

p/scripts/main.js Outdated Show resolved Hide resolved
Frenzie
Frenzie reviewed Aug 23, 2023
View reviewed changes
p/scripts/main.js Outdated Show resolved Hide resolved
math-GH and others added 2 commits August 23, 2023 17:45
@math-GH @Frenzie
Update p/scripts/main.js
83f3380 
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
@math-GH
improved with negative feedback
9b1d8ee
Frenzie
Frenzie approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said I didn't think it was necessary for this PR, but still lgtm. ;-)

@math-GH
Copy link
Contributor Author

math-GH commented Aug 29, 2023

Like I said I didn't think it was necessary for this PR, but still lgtm. ;-)

I used it to learn new stuff ;)

Alkarex
Alkarex reviewed Aug 29, 2023
View reviewed changes
p/scripts/main.js Outdated Show resolved Hide resolved
@math-GH @Alkarex
Update p/scripts/main.js
a00203c 
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
@Alkarex Alkarex merged commit da405ce into FreshRSS:edge Aug 29, 2023
1 check passed
@math-GH math-GH deleted the fix-5595 branch August 30, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alkarex Alkarex Alkarex left review comments

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
UI 🎨 User Interfaces
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

[BUG] Copy to clipboard Sharing does not function
3 participants
@math-GH @Frenzie @Alkarex