Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: shortened text strings #5636

Merged
merged 3 commits into from Sep 10, 2023
Merged

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Sep 5, 2023

Follow up of #5420 that shortened this 2 strings from a sentence to a label

Changes proposed in this pull request:

  • i18n

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the I18n 🌍 Translations label Sep 5, 2023
@math-GH math-GH added this to the 1.22.0 milestone Sep 5, 2023
Comment on lines -199 to +198
'last' => '上次檢查:%s',
'current_version' => '當前 版本為',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @den13501 for review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above is more important than this mentioned line ;)

@@ -195,8 +195,8 @@
'changelog' => 'Changelog', // TODO
'check' => '檢查更新',
'copiedFromURL' => 'update.php copied from %s to ./data', // TODO
'current_version' => '當前 FreshRSS 版本為 %s。',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @den13501 for review

@Alkarex
Copy link
Member

Alkarex commented Sep 9, 2023

Ups, there is a little conflict now. I suggest we merge and come back to it when/if we get feedback.

Copy link
Contributor

@den13501 den13501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@math-GH
Copy link
Contributor Author

math-GH commented Sep 10, 2023

Ups, there is a little conflict now. I suggest we merge and come back to it when/if we get feedback.

fixed

@Alkarex Alkarex merged commit 61a2828 into FreshRSS:edge Sep 10, 2023
1 check passed
@math-GH math-GH deleted the follow-up-of-5420 branch September 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants