Fix labels in anonymous mode #5650
Conversation
p/scripts/main.js
Outdated
| html += '<li class="item"><label><input class="checkboxTag" name="t_' + tag.id + '" type="checkbox"' + | ||
| (context.anonymous ? ' disabled="disabled"' : '') + |
There was a problem hiding this comment.
Please have a look into line 1201. The event listener does not make sense in context.anonymous = true on the checkbox.
There was a problem hiding this comment.
The if (checkboxTag) { should do the job, doesn't it? In anonymous mode, this is false
There was a problem hiding this comment.
if (ev.target.closest('.checkboxTag')) is independend of context nor disabled="disabled"
There was a problem hiding this comment.
Indeed, but there is no .checkboxTag in anonymous mode, so the rest is just skipped as it should, isn't it ?
There was a problem hiding this comment.
Sorry, my mistake. Better now?
|
If there is no label assigned then the popup list looks a bit broken:
|
What about now? |
IMHO it does not make sense to list all (incl. not used) labels in the anonym. mode
I would see follwing 2 options in case of that there is no label added:
|
This reverts commit 24dfba5.
|
I have added a message when there are no labels.
I would like to keep the labels also in anonymous mode, as there are more features coming related to labels (such as automatic labelling). |
|
No labels style improved. |
|
It looks fine now. Does it make sense to keep the background color while hovering in this situation? There is no click action behind. As a user I would expect something there
As far as I can oversee it there is no CSS class for the anonym. mode, isn't it? |
I do not mind much, but I find it fine as it is, and I would rather limit the amount of code, especially when specific to a relatively niche feature |
|
Fwiw you might be able to do something with the new :has() selector, but wouldn't it make more sense to simply not show the checkbox instead of disabling it? |
fix #4305
Replaces #4649