Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive base-url #5657

Merged
merged 1 commit into from Sep 15, 2023
Merged

Sensitive base-url #5657

merged 1 commit into from Sep 15, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Sep 14, 2023

#5656 (comment)
Make read-only while waiting for a better approach (which can wait till release 1.23)

image

FreshRSS#5656 (comment)
Make read-only while waiting for a better approach (which can wait till release 1.23)
@Alkarex Alkarex added this to the 1.22.0 milestone Sep 14, 2023
@math-GH
Copy link
Contributor

math-GH commented Sep 14, 2023

Side note:
Just the input is marked as disabled. If you delete the disabled="disabled" via browser dev tools, then the admin can change and save the input.

@Alkarex
Copy link
Member Author

Alkarex commented Sep 15, 2023

If you delete the disabled="disabled"

Yes, I see that more as a feature for now :-)

@Alkarex Alkarex merged commit 0beabc3 into FreshRSS:edge Sep 15, 2023
1 check passed
@Alkarex Alkarex deleted the sensitive-base-url branch September 15, 2023 06:20
@@ -25,8 +25,9 @@
<label class="group-name" for="base-url"><?= _t('admin.system.base-url') ?></label>
<div class="group-controls">
<input type="text" id="base-url" name="base-url" value="<?= FreshRSS_Context::$system_conf->base_url ?>"
data-leave-validation="<?= FreshRSS_Context::$system_conf->base_url ?>"/>
data-leave-validation="<?= FreshRSS_Context::$system_conf->base_url ?>" disabled="disabled" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OctopusET OctopusET mentioned this pull request Apr 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants