Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RemoteIPInternalProxy directive of remoteip Apache module #5740

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented Oct 25, 2023

instead of RemoteIPTrustedProxy directive

To allow internal IPs to be trusted: for internal clients, and also for the case of chained internal reverse-proxies

Fixes #5726

Changes proposed in this pull request:

  • replace RemoteIPTrustedProxy directive by RemoteIPInternalProxy in Apache configuration

How to test the feature manually:

Follow test-case of #5726

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

instead of RemoteIPTrustedProxy directive

To allow internal IPs to be trusted: for internal clients,
and also for the case of chained internal reverse-proxies

Fixes FreshRSS#5726
@Alkarex Alkarex added this to the 1.22.1 milestone Oct 25, 2023
@Alkarex Alkarex added Security 🛡️ Docker Everything related to Docker labels Oct 25, 2023
@Alkarex Alkarex marked this pull request as ready for review October 25, 2023 14:16
Copy link
Member

@Alkarex Alkarex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alkarex Alkarex merged commit 5374df3 into FreshRSS:edge Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Everything related to Docker Security 🛡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong IP logged with several internal proxies or internal network IPs
2 participants