Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev updates with stylelint-stylistic #5766

Merged
merged 1 commit into from Oct 28, 2023
Merged

Dev updates with stylelint-stylistic #5766

merged 1 commit into from Oct 28, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Oct 28, 2023

fix #5592

@Alkarex Alkarex added the System care Everything related to the system care label Oct 28, 2023
@Alkarex Alkarex added this to the 1.22.1 milestone Oct 28, 2023
@Alkarex Alkarex merged commit 1aa43e8 into FreshRSS:edge Oct 28, 2023
1 check passed
@Alkarex Alkarex deleted the dev-updates branch October 28, 2023 12:38
@math-GH
Copy link
Contributor

math-GH commented Oct 29, 2023

After npm update I get this warning:

Deprecation warnings:
 - The "scss/at-import-no-partial-leading-underscore" rule is deprecated.
 - 'at-import-no-partial-leading-underscore' has been deprecated, and will be removed in '6.0'. Use 'load-no-partial-leading-underscore' instead. See: https://github.com/stylelint-scss/stylelint-scss/blob/v5.2.1/src/rules/at-import-no-partial-leading-underscore/README.md

But I cannot find where we use the at-import-no-partial-leading-underscore rule

@Alkarex
Copy link
Member Author

Alkarex commented Oct 29, 2023

But I cannot find where we use the at-import-no-partial-leading-underscore rule

We do not directly. It is a sub-dependency.

@math-GH
Copy link
Contributor

math-GH commented Oct 30, 2023

Do you have any idea how to fix it?

@Alkarex
Copy link
Member Author

Alkarex commented Oct 30, 2023

Wait till the dev dependencies gets updated, or propose a PR to stylelint-scss/stylelint-config-recommended-scss#251

@Alkarex
Copy link
Member Author

Alkarex commented Oct 30, 2023

P.S. I am on it

@Alkarex
Copy link
Member Author

Alkarex commented Oct 30, 2023

stylelint-scss/stylelint-config-recommended-scss#252

@Alkarex
Copy link
Member Author

Alkarex commented Oct 30, 2023

@math-GH Please try to replace in our package.json:

"stylelint-config-recommended-scss": "git+https://github.com/Alkarex/stylelint-config-recommended-scss.git#load-no-partial-leading-underscore",

@Alkarex
Copy link
Member Author

Alkarex commented Oct 30, 2023 •
edited

If you want @math-GH , we could even use my GitHub branch while waiting for the upstream merge

@math-GH
Copy link
Contributor

math-GH commented Oct 30, 2023

@math-GH Please try to replace in our package.json:

"stylelint-config-recommended-scss": "git+https://github.com/Alkarex/stylelint-config-recommended-scss.git#load-no-partial-leading-underscore",

great, that helped and works fine

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Oct 30, 2023
@Alkarex
Branch stylelint-config-recommended-scss
00ff2d0 
FreshRSS#5766 (comment)
While waiting upstream merge stylelint-scss/stylelint-config-recommended-scss#252
@Alkarex Alkarex mentioned this pull request Oct 30, 2023
Merged
Alkarex added a commit that referenced this pull request Oct 30, 2023
@Alkarex
Branch stylelint-config-recommended-scss (#5787)
b897bd6 
#5766 (comment)
While waiting upstream merge stylelint-scss/stylelint-config-recommended-scss#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
System care Everything related to the system care
Projects
None yet
Milestone
1.22.1
Development

Successfully merging this pull request may close these issues.

[BUG] .stylelintrc.json: deprecated instuctions
2 participants
@Alkarex @math-GH