Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve table scrolling #5774

Merged
merged 3 commits into from Oct 29, 2023
Merged

Improve table scrolling #5774

merged 3 commits into from Oct 29, 2023

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Oct 29, 2023

When a table is to wide the table should be horizontal scroll-able and not the whole page.

If a table is scroll-able the thin scrollbars should be used (instead of the wider default scroll bars)

After:
grafik

grafik

Changes proposed in this pull request:

  • phtml + CSS (frss.css)

How to test the feature manually:

  1. go to statics pages with table or go to display config page
  2. have a thin screen
  3. scroll the table horizontal

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UX User experience label Oct 29, 2023
@math-GH math-GH added this to the 1.22.1 milestone Oct 29, 2023
Frenzie
Frenzie approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite clear to me why the diff is so large? But fine by me in principle.

@math-GH
Copy link
Contributor Author

math-GH commented Oct 29, 2023

It's not quite clear to me why the diff is so large? But fine by me in principle.

because the table code had to be indented, because of the added <div class="table-wrapper">

@Alkarex Alkarex merged commit baab354 into FreshRSS:edge Oct 29, 2023
1 check passed
@Frenzie
Copy link
Member

Frenzie commented Oct 29, 2023

Right, mobile isn't showing any indentation here.

@math-GH math-GH deleted the improve-table-scrolling branch October 30, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
UX User experience
Projects
None yet
Milestone
1.22.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@math-GH @Frenzie @Alkarex