Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the behavior of favicon search #5839

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Rework the behavior of favicon search #5839

merged 5 commits into from
Nov 10, 2023

Commits on Nov 9, 2023

  1. Rework the behavior of favicon search 

    Use xpath queries to reduce the filtering necessary.

Don't call checkUrl since the href value will not always be a full URL.

Check for a base path in the HTML to be used if the favicon href doesn't
start with a leading slash.
    @jaden
    jaden committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8046a35 View commit details
    Browse the repository at this point in the history

  2. Break long xpath query into two lines

    @jaden
    jaden committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ff3ac25 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'edge' into 5838-adjust-favicon-search

    @jaden
    jaden committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ddd62a0 View commit details
    Browse the repository at this point in the history

  4. Fix issues found by CI

    @jaden
    jaden committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ff84e9e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge branch 'edge' into 5838-adjust-favicon-search

    @jaden
    jaden committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    48782bf View commit details
    Browse the repository at this point in the history