Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS thumbnails #5972

Merged
merged 8 commits into from
Feb 26, 2024
Merged

RSS thumbnails #5972

merged 8 commits into from
Feb 26, 2024

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Dec 23, 2023

fix #5925
Ref keynet#1
Replaces #5971
Ping @keynet

@Alkarex
Copy link
Member Author

Alkarex commented Jan 2, 2024

@keynet Could you please double-check this slightly modified version?

@keynet
Copy link

keynet commented Jan 6, 2024

Excuse my git inexperience - is there a simple way to get the changes from your branch to test, without cloning your repo?

@Alkarex
Copy link
Member Author

Alkarex commented Jan 6, 2024

@keynet How did you install FreshRSS, and do you have access to a command line with git?

@keynet
Copy link

keynet commented Jan 7, 2024

I cloned the Freshrss/freshrss repo, added my working branch and pushed my proposed change back as a PR I have a Linux server and git command line and can test a local version, or branch etc as it's on a vhost in my apache config behind a firewall.

@Alkarex
Copy link
Member Author

Alkarex commented Jan 7, 2024

I cloned the Freshrss/freshrss repo, added my working branch and pushed my proposed change back as a PR I have a Linux server and git command line and can test a local version, or branch etc as it's on a vhost in my apache config behind a firewall.

Ok, then you can try the following command from your directory, and you should have the current PR:

git pull git@github.com:Alkarex/FreshRSS.git rss-thumbnails

@keynet
Copy link

keynet commented Jan 8, 2024

Unfortunately I seem to need permission

git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

@Alkarex
Copy link
Member Author

Alkarex commented Jan 8, 2024

Try with that instead then:

git pull https://github.com/Alkarex/FreshRSS.git rss-thumbnails

@keynet
Copy link

keynet commented Jan 8, 2024

OK, I think I have your branch. It works in Newsblur, but Mailchimp and Freedbro don't see the result of any scraped images in their RSS feeds, which is a problem. I haven;t had time to investigate why

@Alkarex Alkarex merged commit 25166c2 into FreshRSS:edge Feb 26, 2024
2 checks passed
@Alkarex Alkarex deleted the rss-thumbnails branch February 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve images for a range of clients
3 participants