Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed peroid names in the Hungarian translation #6000

Merged
merged 1 commit into from Dec 29, 2023
Merged

Fixed peroid names in the Hungarian translation #6000

merged 1 commit into from Dec 29, 2023

Conversation

andris155
Copy link
Contributor

Changes proposed in this pull request:

  • Fixed peroid names in the Hungarian translation

How to test the feature manually:

  1. Go to Settings -> Display -> Language
  2. Change language to Magyar/Hungarian and Submit.
  3. Language is Hungarian with new translations and fixes.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@Alkarex Alkarex added this to the 1.23.1 milestone Dec 29, 2023
@Alkarex Alkarex added the I18n 🌍 Translations label Dec 29, 2023
@Alkarex Alkarex merged commit 9dec2af into FreshRSS:edge Dec 29, 2023
2 checks passed
@Alkarex
Copy link
Member

Alkarex commented Dec 29, 2023

Thanks!

@Alkarex
Copy link
Member

Alkarex commented Dec 29, 2023

P.S. It looks there is a single line lacking a translation in Hungarian :-)

'help' => 'About <a href="https://freshrss.github.io/FreshRSS/en/users/WebSub.html" target="_blank">WebSub</a>', // TODO

@Alkarex
Copy link
Member

Alkarex commented Dec 29, 2023

And congrats with PR number 6000 🎆

@andris155
Copy link
Contributor Author

P.S. It looks there is a single line lacking a translation in Hungarian :-)

'help' => 'About <a href="https://freshrss.github.io/FreshRSS/en/users/WebSub.html" target="_blank">WebSub</a>', // TODO

TODO is also written for this line in the English translation. What is the final English translation that can be translated?

https://github.com/FreshRSS/FreshRSS/blob/edge/app/i18n/en/admin.php#L197

@Frenzie
Copy link
Member

Frenzie commented Dec 29, 2023

I suspect it only says todo because the documentation wasn't online yet at the time it was added.

@Alkarex
Copy link
Member

Alkarex commented Dec 29, 2023

The command line for adding new i18n strings also puts a TODO in the English version, which is sometimes forgotten afterwards. It is a mistake and should be stripped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants