PHPStan prepare exceptions #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: FreshRSS#5504 Preparation needed before new PRs of the same type: FreshRSS#5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block.
Alkarex
commented
Jan 13, 2024
Comment on lines
+53
to
+59
| exceptions: | ||
| check: | ||
| missingCheckedExceptionInThrows: false # TODO pass | ||
| tooWideThrowType: true | ||
| implicitThrows: false | ||
| checkedExceptionClasses: | ||
| - 'Minz_Exception' |
There was a problem hiding this comment.
This is the goal of this PR
This was referenced Jan 13, 2024
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of
https://phpstan.org/blog/bring-your-exceptions-under-control
Minimum changes to pass
tooWideThrowTypeandimplicitThrows.Revert some mistakes from:
#5504
Preparation needed before new PRs of the same type:
#5962
Fix several wrong PHPDocs and catches: