version_compare raise exception if param is not a string #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a string. in this case the check of the version raise an exception.
|
Good idea to make a fix in |
Alkarex
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file "metadata.json" of extensions it's possible that the data of version is not a string. In this case the check of the version raises an exception. see issue
Ex. Auto-Refresh-Extension
Maybe the file generate.php could fix this issue with additional line '$metadata['version'] = strval($metadata[' version']);' before line 58 instead of this PR.
Pull request checklist: