Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add -it to make start to allow for Ctrl+C SIGTERM #6239

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Mar 26, 2024

How to test the feature manually:

  1. make start
  2. Ctrl + C
  3. It stops, which is much easier than running docker stop… (make stop) from another terminal.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Alkarex Alkarex merged commit 5d1493b into edge Mar 26, 2024
2 checks passed
@Alkarex Alkarex deleted the Frenzie-patch-2 branch March 26, 2024 20:53
@Alkarex Alkarex added this to the 1.24.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants