Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clicking outside of article text area closes the article #6241

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Mar 28, 2024

Before:
If Clicking outside of article text area closes the article in Reading config is enabled, then.....

if the user clicks in the article footer on a white space, then the article will be closed
grafik

After:
A click on the footer does not close the article.

Changes proposed in this pull request:

  • if click on the footer: do nothing

How to test the feature manually:
Clicking outside of article text area closes the article is enabled:

  1. click left or right hand side of the article: article will be closed
  2. click on a white space in the footer: article will NOT be closed
  3. click on My labels or tags or Share: dropdown will be opened and the article will NOT be closed

Clicking outside of article text area closes the article is disabled:

  1. click left or right hand side of the article: article will NOT be closed
  2. click on a white space in the footer: article will NOT be closed
  3. click on My labels or tags or Share: dropdown will be opened and the article will NOT be closed

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UX User experience label Mar 28, 2024
@math-GH math-GH added this to the 1.24.0 milestone Mar 28, 2024
@Alkarex Alkarex merged commit 75a17ff into FreshRSS:edge Mar 28, 2024
2 checks passed
@math-GH math-GH deleted the fix-clicking-outside-footer branch March 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants