Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimplePie absolutize URL for several cases #6270

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 6, 2024

This is especially relevant for HTML+XPath mode, for which we rely on proper URL "absolutize"

This lead to broken article links, broken images.
fix #6152

Upstream PR simplepie/simplepie#861

This is especially relevant for HTML+XPath mode, for which we rely on proper URL "absolutize"

Upstream PR simplepie/simplepie#861
@Alkarex Alkarex added SimplePie 🍰 Bug (confirmed) 🐞 issues that are reproducable labels Apr 6, 2024
@Alkarex Alkarex added this to the 1.24.0 milestone Apr 6, 2024
@Alkarex Alkarex linked an issue Apr 6, 2024 that may be closed by this pull request
@Alkarex
Copy link
Member Author

Alkarex commented Apr 8, 2024

Merging to get more tests, but feedback still welcome

@Alkarex Alkarex merged commit 6e12781 into FreshRSS:edge Apr 8, 2024
2 checks passed
@Alkarex Alkarex deleted the simplepie-861 branch April 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (confirmed) 🐞 issues that are reproducable SimplePie 🍰
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] XPath URL uses thumbnail's hostname
1 participant