Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 #[\Override] #6273

Merged
merged 3 commits into from
Apr 10, 2024
Merged

PHP 8.3 #[\Override] #6273

merged 3 commits into from
Apr 10, 2024

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 7, 2024

https://php.watch/versions/8.3/override-attr

With PHPStan checkMissingOverrideMethodAttribute https://phpstan.org/config-reference#checkmissingoverridemethodattribute

And modified the call to phpstan-next on the model of FreshRSS/Extensions#228 (more robust than the find method, which gave some strange errors)

https://php.watch/versions/8.3/override-attr

With PHPStan `checkMissingOverrideMethodAttribute` https://phpstan.org/config-reference#checkmissingoverridemethodattribute

And modified the call to phpstan-next on the model of FreshRSS/Extensions#228 (more robust than the find method, which gave some strange errors)
@Alkarex Alkarex merged commit 350edf3 into FreshRSS:edge Apr 10, 2024
2 checks passed
@Alkarex Alkarex deleted the php8.3-override branch April 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant