SimplePie replace iframe allow attribute #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allow Besides security, the `allow autoplay` atttribute is especially problematic on mobile (Firefox on Android) as it asks to open the YouTube app as soon as the article is opened. Example of code before: ```html <iframe data-original="https://www.youtube.com/embed/??????feature=oembed" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen="" sandbox="allow-scripts allow-same-origin"></iframe> ```
Alkarex
changed the title
Alkarex
commented
Apr 8, 2024
| $simplePie->add_attributes([ | ||
| 'audio' => ['controls' => 'controls', 'preload' => 'none'], | ||
| 'iframe' => [ | ||
| 'allow' => 'accelerometer; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share', |
There was a problem hiding this comment.
Relevant line, which does not include autoplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allow
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy#iframes
Besides security, the
allow autoplayatttribute is especially problematic on mobile (Firefox on Android) as it asks to open the YouTube app as soon as the article is opened.So we allow what is needed for a YouTube video to work fine, but not autoplay.
Example of code before:
Example of feed https://www.lexpress.fr/arc/outboundfeeds/rss/alaune.xml