Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Reading view: author #6289

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 12, 2024

Reader view:

Before:
Author information was smaller then the date (90%).
Just the name was given while the normal view has a "by:" pre-string
grafik

After:
Same font size as the date.
"By:" is given.
grafik

Before:
no author is given but 2 dots are shown:
grafik

After:
no author and just 1 dot to separate the date
grafik

Changes proposed in this pull request:

  • the margin: 0 0 10px moved from the themes into frss.css

How to test the feature manually:

  1. use the reading view
  2. have an article with author(s)
  3. have an article without author(s)

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 12, 2024
@math-GH math-GH added this to the 1.24.0 milestone Apr 12, 2024
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size thing is presumably on purpose, but I agree it seems a bit unexpected and unnecessary.

@math-GH
Copy link
Contributor Author

math-GH commented Apr 12, 2024

The size thing is presumably on purpose, but I agree it seems a bit unexpected and unnecessary.

The line was already on 0.9rem and the author 90% of it.
IMHO 0.9rem is small enough.

@math-GH
Copy link
Contributor Author

math-GH commented Apr 15, 2024

This PR will fix #6296 too

@Alkarex Alkarex merged commit bf68205 into FreshRSS:edge Apr 15, 2024
2 checks passed
@math-GH math-GH deleted the reading-view-author branch April 15, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Reading view: Search for an author by clicking on the author name
3 participants