Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved: Gap between header and first image #6299

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 14, 2024

In some rare cases the first image is not wrapped into a <p> so that there is no gap between the header and the image (the <p> has some margin).

Before:
grafik

After:
grafik

Changes proposed in this pull request:

  • padding-bottom added

How to test the feature manually:

  1. a useful feed could be: https://gizmodo.com/rss
  2. normal view/reading view
  3. see the gap over the image

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 14, 2024
@math-GH math-GH added this to the 1.24.0 milestone Apr 14, 2024
@math-GH math-GH changed the title imroved: Gap between header and first image improved: Gap between header and first image Apr 14, 2024
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And when there's a <p> with margin the margins collapse I presume?

@Alkarex Alkarex merged commit 6901ff1 into FreshRSS:edge Apr 14, 2024
2 checks passed
@math-GH math-GH deleted the fix-gap-between-headline-body branch April 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants