Fix updated entry filters

[Alkarex]

fix #6331

[hkcomori]

entry_auto_unread is called before the filter marks articles as read.
I think not calling it for filtered articles because they will be marked as read finally.

[Alkarex]

The action filters are designed to perform more things than just marking as read (although not everything is implemented yet). Already read articles will be skipped a bit later:

FreshRSS/app/Models/Entry.php

Line 661 in 0ffcf41

if (!$this->isRead()) {

But let me know if you spot any bug in the logic

[hkcomori]

Oh, not that part.
I think the following part calls entry_auto_unread before filter action.

FreshRSS/app/Controllers/feedController.php

Lines 580 to 583 in 094ebf9

	$entry->_isRead($mark_updated_article_unread ? false : null); //Change is_read according to policy.
	if ($mark_updated_article_unread) {
	Minz_ExtensionManager::callHook('entry_auto_unread', $entry, 'updated_article');
	}

Then apply the filter action:

FreshRSS/app/Controllers/feedController.php

Line 591 in 094ebf9

$entry->applyFilterActions($titlesAsRead);

Articles matching filter action are marked as read finally even though entry_auto_unread was called.
But when entry_auto_unread was called, I will think articles have been marked as unread (in fact it was marked as read).
So, I think it would be better if entry_auto_unread only calls for articles that it finally marks as unread.

Please let me know if my understanding is wrong.

[hkcomori]

Sorry, please forget my comment.

Hook call behavior is a different topic and seems to be consistent with existing policy.
The existing code calls entry_auto_unread for no read status change too (unread -> unread).

It seems there is not need to change, because no problems have occurred now.

[Alkarex]

Thanks for commenting again. I had not had time yet to investigate and was about to do so :-)