Refactoring: Rename dotpath into dotnotation #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
reviewed
Apr 21, 2024
| @@ -161,8 +161,8 @@ private function createFeed(array $feed_elt, FreshRSS_Category $category, bool $ | |||
| case strtolower(FreshRSS_Export_Service::TYPE_XML_XPATH): | |||
| $feed->_kind(FreshRSS_Feed::KIND_XML_XPATH); | |||
| break; | |||
| case strtolower(FreshRSS_Export_Service::TYPE_JSON_DOTPATH): | |||
| $feed->_kind(FreshRSS_Feed::KIND_JSON_DOTPATH); | |||
| case strtolower(FreshRSS_Export_Service::TYPE_JSON_DOTNOTATION): | |||
There was a problem hiding this comment.
It might be sufficient to add another case line here to support OPML exports with the previous name
There was a problem hiding this comment.
I am not so a big fan of having legacy code because of changed feature within a dev release, but it is ok.
There was a problem hiding this comment.
Tested to work.
edge is our rolling release, and there are likely many users of the JSON feature already, so avoiding breaking changes is always good. I have myself this feature deployed on multiple instances already.
Alkarex
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6317
renaming from dot path to dot notation
(for a better review: go through each commit. I tried to bundle it in each commit)
It will affect exported OPMLs that were already exported and hat dotpath information. But it was published as dev version, so I would say that it is okay to rename the attribute.