Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user query filter display #6421

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented May 1, 2024

fix #6360

@math-GH
Copy link
Contributor

math-GH commented May 1, 2024

Quite better as before PR.

What I think is not good working right now:
"Empty filter" text, if there is no expression and the main stream chosen.
grafik

If you select this query f.e. in the view of favorites, than it would jump to the main stream.
If you would select this query in the main stream, but you have the "show only unread articles, then it would show unread and read articles after reloading.

One more thought: Does it make sense to keep the "no filter" text? I would say that every query is a valid filter.

If the expression is mandatory then we should mark it as mandatory (via require attribute)

@Alkarex
Copy link
Member Author

Alkarex commented May 2, 2024

The search expression is not mandatory. We could indeed remove the no filter. Let's keep that for another PR, as it is less urgent for 1.24.0.

@Alkarex Alkarex merged commit 617f9a7 into FreshRSS:edge May 2, 2024
2 checks passed
@Alkarex Alkarex deleted the fix_user_query_display branch May 2, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] User Queries: different displays - depends on selecting main stream or not
2 participants