Improved: side navigation headlines #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nord theme: now it has the same padding as the other navigation sidebars: 1rem (instead of 2rem). Influenced by the discussion of #6429
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It made me odd to see this. Once seen it cannot be made unseen anymore.
Before:
Origine theme (and Dark and Pafat) has a border at the BOTTOM of the navigation section headlines. It looks like to separate the headline from the sub items below while it has no border at the TOP. But the semantic meaning is other way around: headline is semantically connected to the sub items below and separated to the navigation above.
After:
no border at the bottom (and at the top) of headline.
Each section has a little margin to the next headline.
Changes proposed in this pull request:
How to test the feature manually:
chose a theme and see the navigation on the left hand side
Pull request checklist: