Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opcache bug #4

Merged
merged 1 commit into from Sep 20, 2022
Merged

Fix opcache bug #4

merged 1 commit into from Sep 20, 2022

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Sep 19, 2022

Copy link
Member

@marienfressinaud marienfressinaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why both this PR and FreshRSS/FreshRSS#4629 are needed. Shouldn't the latter be enough?

@Alkarex
Copy link
Member Author

Alkarex commented Sep 20, 2022

This one is the most urgent, to fix the current updates. The one in FreshRSS core is more a "better safe than sorry" (especially while waiting for moving all those utility functions to core FreshRSS/FreshRSS#1760 ) so could be omitted

@marienfressinaud marienfressinaud merged commit 979038b into master Sep 20, 2022
@marienfressinaud marienfressinaud deleted the fix-opcache-bug branch September 20, 2022 08:12
@marienfressinaud
Copy link
Member

Merged and deployed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't update, white screen PHP Fatal error: Uncaught Error: Undefined constant "LOG_FILENAME"
2 participants