Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logger.rb #204

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update logger.rb #204

wants to merge 1 commit into from

Conversation

quinn
Copy link

@quinn quinn commented Jul 9, 2019 •
edited

this should allow to do:

Technologic::Logger.warn(...)

@quinn quinn requested a review from garside July 9, 2019 22:01
@garside garside added this to the Spicerack Creation milestone Jul 11, 2019
@garside garside added the Feature Adds new behavior. label Jul 11, 2019
@garside
Copy link
Contributor

garside commented Aug 8, 2019 •
edited

@quinn Mm I would suggest this be class methods on the main class instead? That seems like a cleaner DSL imo:

Technologic.warn()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garside garside Awaiting requested review from garside

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Adds new behavior.
Projects
None yet
Milestone
Spicerack Creation
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quinn @garside