Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert changes to squish arguments and options into the one variable #259

Merged
merged 2 commits into from
Oct 18, 2019
Merged

revert changes to squish arguments and options into the one variable #259

merged 2 commits into from
Oct 18, 2019

Conversation

nplusp
Copy link
Contributor

@nplusp nplusp commented Oct 16, 2019

No description provided.

@nplusp nplusp changed the title Do not pass arguments if method does not accept any revert changes to squish arguments and options into the one variable Oct 17, 2019
arettberg
arettberg approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@arettberg arettberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against a few different codebases, works fine 👍

@arettberg arettberg merged commit 690f4f7 into develop Oct 18, 2019
@arettberg arettberg deleted the nplusp-patch-1 branch October 18, 2019 15:21
@arettberg arettberg added this to the Spicerack Creation milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arettberg arettberg arettberg approved these changes

@garside garside Awaiting requested review from garside

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spicerack Creation
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nplusp @arettberg