ARCH-2109 ensure errors.messages doesn't raise in have_error_on_attribute matcher

[MichelleMik]

https://freshly.atlassian.net/browse/ARCH-2109

To test :
Use referral service branch: ARCH-2019-rraise-on-missing-i18n-translations-in-development, and run the specs . They should be all green .

update spicerack line in Gemfile to following :
gem "spicerack", git: "git@github.com:Freshly/spicerack.git", branch: "ARCH-2109-assert-have-error-on-attribute-matcher-doesnt-raise"

run bundle install

run the rspecs, you should have a failure for a missing translation :

  1) CreateExtoleReferralState Validations #identity_token_present? when the referrer does not have an identity_token behaves like an invalid state returns the correct error message
     Failure/Error: expect(state).to have_error_on_attribute(attribute).with_detail_key(expected_key)

     I18n::MissingTranslationData:
       translation missing: en.activemodel.errors.models.create_extole_referral_state.attributes.identity_token.referrer_must_have_identity_token

[arettberg]

this seems a little heavy-handed. maybe record.errors[attribute] just to limit the scope?

[tbconroy]

Maybe raise_error shouldn't take an argument I18n::MissingTranslationData since that is specific to our use case and this is a public gem. expect(record.errors[attribute.to_sym]).to_not raise_error should still work.

[MichelleMik]

sure

[tbconroy]

@MichelleMik question: are there no tests to test this matcher? That might be a dumb question 😬

[MichelleMik]

@MichelleMik question are there no tests to test this matcher? That might be a dumb question 😬

@tbconroy didnt find any

[pearlshin]

tested locally 👍