Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Add Impulse Switches and Position Sensor #24

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Add Impulse Switches and Position Sensor #24

merged 2 commits into from
Feb 20, 2023

Conversation

Taraman17
Copy link
Contributor

This adds impulse switches and position sensors.

Please test thoroughly, if this does not break other switches/plugs.

@Taraman17
Copy link
Contributor Author

Additional linebreaks were added by vscode automatically on saving...

@FreshlyBrewedCode
Copy link
Owner

Thanks for the PR. I am unable to test this because I am not a homee user anymore. However, the changes look good to me. If there are any problems, it is still possible to roll back to an earlier version, so no worries.

@FreshlyBrewedCode FreshlyBrewedCode merged commit c8ac711 into FreshlyBrewedCode:master Feb 20, 2023
@FreshlyBrewedCode
Copy link
Owner

Actually, I just realized, we might need to make sure the latest version of pymee is included.

@Taraman17
Copy link
Contributor Author

For me, HA installed the latest version on reboot.

@FreshlyBrewedCode
Copy link
Owner

I just bumped pymee in the manifest to the latest version so should be all good now: 90a037e

@Taraman17
Copy link
Contributor Author

Great thanks.

When working on the code, I noticed some Deprecation notices from HA.
Is it ok, If I address these in a next step?

Don't want to work too much in your code without your approval...

@FreshlyBrewedCode
Copy link
Owner

Feel free to do whatever you want. This is open source for a reason. I don't really have any stakes in this project anymore. I will keep passively maintaining if it is not too much work. If you however are planning to make major changes that would require a lot of work to test/review I would probably encourage you to fork the project, since I won't invest too much time in this here anymore.

@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Taraman17 Taraman17 mentioned this pull request Feb 24, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants