isVerticalItemLabel feature added #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frezyx
requested changes
Jan 31, 2022
Comment on lines
53
to
75
| theme.isVerticalItemLabel | ||
| ? SizedBox( | ||
| height: 2, | ||
| ) | ||
| : SizedBox( | ||
| width: 2, | ||
| ), | ||
| theme.isVerticalItemLabel | ||
| ? Text( | ||
| model.label!, | ||
| style: isSelected | ||
| ? theme.selectedItemTextStyle | ||
| : theme.itemTextStyle, | ||
| ) | ||
| : Expanded( | ||
| flex: 2, | ||
| child: Text( | ||
| model.label!, | ||
| style: isSelected | ||
| ? theme.selectedItemTextStyle | ||
| : theme.itemTextStyle, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Please use the spread operator to the list
if(theme.isVerticalItemLabel)...[
SizedBox(height: 2,),
Text(
model.label!,
style: isSelected ? theme.selectedItemTextStyle : theme.itemTextStyle,
),]
else ...[| } | ||
|
|
||
| List<Widget> get _items { | ||
| final items = <Widget>[ | ||
| theme.isVerticalItemLabel ? SizedBox() : Spacer(), |
There was a problem hiding this comment.
if(theme.isVerticalItemLabel) Spacer()There was a problem hiding this comment.
My bad
I didn't pay attention for logic
There was a problem hiding this comment.
Real logic
if(!theme.isVerticalItemLabel) Spacer()
|
Thank you @coskuncay for this contribution ! |
|
All requested changes are applied , thank you ! @Frezyx |
Frezyx
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isVerticalItemLabel feature makes the labels of the items appear vertically or horizontally.
| 