-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0) #107
base: master
Are you sure you want to change the base?
Conversation
… the button's border - Added disableTappingShadow property, to remove the ElevatedButton's shadow upon tapping in case the user requires a flat look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JaseElder !
Thanks a lot for this contribution
Can we fix review issues before merge ?
lib/src/group_button_body.dart
Outdated
final List<BoxShadow> unselectedShadow; | ||
final bool? disableTappingShadow; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if we could provide a default field shadowColor for more customization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea! I'll amend.
I'm not sure whether I've done the right thing with this PR edit, but it looks like the new changes are there... |
When does border width apply? |
Border width is by default set to 1, but a borderWidth can be provided in GroupButtonOptions() if it needs to be other than 1. |
Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0)