Reviewed code #93
Merged
Reviewed code #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frezyx
requested changes
Aug 21, 2022
| final _radioButtons = [ | ||
| final List<String> _radioButtons = [ |
There was a problem hiding this comment.
Why did you add types where it is not necessary ?
Comment on lines
16
to
17
| final List<String> _checkboxButtons = [ | ||
| 'Michael Jordan', |
Comment on lines
53
to
60
| final theme = Theme.of(context); | ||
| final ThemeData theme = Theme.of(context); |
| final controller = GroupButtonController( | ||
| final GroupButtonController controller = GroupButtonController( |
Comment on lines
+10
to
+14
| final GroupButtonController controller = GroupButtonController( | ||
| onDisablePressed: (i) => debugPrint('Disable Button #$i pressed'), | ||
| ); | ||
| final customizableController = CustomizableExampleController(); | ||
| final CustomizableExampleController customizableController = | ||
| CustomizableExampleController(); |
lib/src/options/defaults.dart
Outdated
Comment on lines
17
to
26
| const defaultSelectedTextStyle = TextStyle(fontSize: 14, color: Colors.white); | ||
| const TextStyle defaultSelectedTextStyle = TextStyle( | ||
| fontSize: 14, | ||
| color: Colors.white, | ||
| ); | ||
|
|
||
| @protected | ||
| const defaultUnselectedTextStyle = TextStyle(fontSize: 14, color: Colors.black); | ||
| const TextStyle defaultUnselectedTextStyle = TextStyle( | ||
| fontSize: 14, | ||
| color: Colors.black, | ||
| ); |
Comment on lines
-8
to
+9
| List<int> selectedIndexes = const <int>[], | ||
| List<int> disabledIndexes = const <int>[], | ||
| List<int> selectedIndexes = const [], | ||
| List<int> disabledIndexes = const [], |
There was a problem hiding this comment.
For what you did it ?
It's your own linter rules ?
Comment on lines
+21
to
23
| /// Returns int [index] of selected button | ||
| Function(int index)? onDisablePressed; | ||
|
|
| /// Custom builder method to create custom buttons by index | ||
| /// Custom builder method to create custom buttons by value |
Comment on lines
+11
to
+14
| class Routes { | ||
| /// Use [GroupButtonExtendedExample] | ||
| /// to check all package [GroupingType]'s in one place | ||
| static const groupButtonExtendedExample = '/GroupButtonExtendedExample'; |
|
Hello @anasfik ! But please check comments and effective dart docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just reviewed the code, specified types, fixed an overflow problem, separated the routes to a single file