Marionette capability should be optional #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The marionette capability is a Firefox-specific capability to aid in the transition from legacy versions of Firefox (47.0.1 and earlier). It is a `Boolean` and this value is now checked aggressively in Selenium 4.0.0 onwards. Since `null` is not a Boolean, this leads to an error. This patch removes the default value, which means that if no value is specified then it will not be included in the output, and the defaults will apply (True for Firefox; Unset for other browsers). Without this patch you must jump through hoops to run against Selenium 4. Fixes Behat#376
|
@andrewnicols can you please rebase for master? In master merge new Ci) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marionette capability is a Firefox-specific capability to aid in the
transition from legacy versions of Firefox (47.0.1 and earlier).
It is a
Booleanand this value is now checked aggressively in Selenium4.0.0 onwards. Since
nullis not a Boolean, this leads to an error.This patch removes the default value, which means that if no value is
specified then it will not be included in the output, and the defaults
will apply (True for Firefox; Unset for other browsers).
Without this patch you must jump through hoops to run against Selenium
4.
Fixes Behat#376