Skip to content

Commit

Permalink
Add support for Symfony 4.4 and 5.0; remove for 4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
pamil committed Nov 26, 2019
1 parent 3123c7e commit 079a08c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ php:

env:
- SYMFONY_VERSION=3.4.*
- SYMFONY_VERSION=4.2.*
- SYMFONY_VERSION=4.3.*
- SYMFONY_VERSION=4.4.*
- SYMFONY_VERSION=5.0.*

cache:
directories:
Expand All @@ -23,6 +24,7 @@ install:
- composer require symfony/proxy-manager-bridge:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
- composer require --dev symfony/browser-kit:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
- composer require --dev symfony/framework-bundle:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
- composer require --dev symfony/process:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
- composer require --dev symfony/yaml:${SYMFONY_VERSION} --no-update --no-scripts --prefer-dist
- composer update --prefer-dist

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<h1 align="center">SymfonyExtension</h1>

This Behat extension provides an integration with Symfony (both `^3.4` and `^4.3`) and Mink driver for Symfony application.
This Behat extension provides an integration with Symfony (both `^3.4`, `^4.3` and `^5.0`) and Mink driver for Symfony application.

It allows for:

Expand Down
13 changes: 7 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
"require": {
"php": "^7.1",
"behat/behat": "^3.4",
"symfony/dependency-injection": "^3.4|^4.2",
"symfony/http-kernel": "^3.4|^4.2",
"symfony/proxy-manager-bridge": "^3.4|^4.2"
"symfony/dependency-injection": "^3.4|^4.3|^5.0",
"symfony/http-kernel": "^3.4|^4.3|^5.0",
"symfony/proxy-manager-bridge": "^3.4|^4.3|^5.0"
},
"require-dev": {
"behat/mink": "^1.7",
Expand All @@ -25,9 +25,10 @@
"friends-of-behat/service-container-extension": "^1.0",
"phpstan/phpstan-shim": "^0.11",
"sylius-labs/coding-standard": "^3.0",
"symfony/browser-kit": "^3.4|^4.2",
"symfony/framework-bundle": "^3.4|^4.2",
"symfony/yaml": "^3.4|^4.2"
"symfony/browser-kit": "^3.4|^4.3|^5.0",
"symfony/framework-bundle": "^3.4|^4.3|^5.0",
"symfony/process": "^3.4|^4.3|^5.0",
"symfony/yaml": "^3.4|^4.3|^5.0"
},
"suggest": {
"behat/mink-browserkit-driver": "^1.3"
Expand Down
3 changes: 1 addition & 2 deletions tests/Behat/Context/TestContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,7 @@ public function iRunBehat(): void
$executablePath = $this->thereIsFile('__executable.php', $content);
}

$this->process = new Process(sprintf('%s %s --strict -vvv --no-interaction --lang=en', self::$phpBin, escapeshellarg($executablePath)));
$this->process->setWorkingDirectory(self::$workingDir);
$this->process = new Process([self::$phpBin, $executablePath, '--strict', '-vvv', '--no-interaction', '--lang=en'], self::$workingDir);
$this->process->start();
$this->process->wait();
}
Expand Down

0 comments on commit 079a08c

Please sign in to comment.