Skip binary check #324
Open
Skip binary check #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
commented
Jul 21, 2023
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "name": "friendsofcake/cakepdf", | |||
| "name": "kongka/cakepdf", | |||
There was a problem hiding this comment.
Those things should be reverted though then, or make a fresh branch with only relevant changes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
============================================
+ Coverage 50.84% 54.17% +3.33%
- Complexity 212 213 +1
============================================
Files 10 10
Lines 535 587 +52
============================================
+ Hits 272 318 +46
- Misses 263 269 +6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if some of the community improvements should be merged back into master at some point?