Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery version. #352

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Update jquery version. #352

merged 1 commit into from
Jun 11, 2021

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Jun 11, 2021

Closes #351

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #352 (4ed435f) into master (7de9eeb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage     99.25%   99.25%           
  Complexity      329      329           
=========================================
  Files            21       21           
  Lines           934      934           
=========================================
  Hits            927      927           
  Misses            7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de9eeb...4ed435f. Read the comment docs.

@ndm2
Copy link
Collaborator

ndm2 commented Jun 11, 2021

Not sure how good Bootstrap and Popper are with regards to not breaking things in patch releases, but should we maybe consider dropping the .lock file, so that users can easily get the latest patch versions?

@ADmad
Copy link
Member Author

ADmad commented Jun 11, 2021

Whatever you see fit. I don't use the css/js provideed through the plugin (nor any templates for that matter) so I don't care 🙂.

@ndm2
Copy link
Collaborator

ndm2 commented Jun 11, 2021

Well, I don't want to be the one who breaks everybody's stuff 😄

@ADmad
Copy link
Member Author

ADmad commented Jun 11, 2021

Everyone lib maintainer does that sooner or later 😂.

@ndm2
Copy link
Collaborator

ndm2 commented Jun 11, 2021

Yeah, well... let's leave that for another day 🙃 Maybe we can give it a try with for BS5.

@ADmad ADmad merged commit 7dcf728 into master Jun 11, 2021
@ADmad ADmad deleted the issue-351 branch June 11, 2021 15:17
@ndm2 ndm2 mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse doesn't work with jQuery v3.5.0
2 participants