Improve ARIA attribute handling. #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `aria-required`, `aria-invalid`, and error element IDs for compatibility with new ARIA attribute support added for CakePHP 4.3. Also adds support for having the help element ID as well as the error element ID set for `aria-describedby`. This helps to avoid losing the association depending on a control's error state.
Codecov Report
@@ Coverage Diff @@
## bs5 #355 +/- ##
============================================
+ Coverage 99.29% 99.32% +0.02%
- Complexity 332 353 +21
============================================
Files 21 21
Lines 994 1031 +37
============================================
+ Hits 987 1024 +37
Misses 7 7
Continue to review full report at Codecov.
|
dereuromark
reviewed
Oct 25, 2021
| * | ||
| * @var string|null | ||
| */ | ||
| private $_errorFieldName = null; |
There was a problem hiding this comment.
can we please use protected?
There was a problem hiding this comment.
We could, but I made it private on purpose, as it's part of a workaround that I'd like to drop at first chance, and I don't want anyone extending the helper (I know, the likelihood is tiny) to make use of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting the new ARIA attributes that are coming with 4.3 required a bit of hack here, but it could've been worse. It can be removed later once the minimum CakePHP version required by this plugin is bumped accordingly.