Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 4.3 compatibility #356

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

ndm2
Copy link
Collaborator

@ndm2 ndm2 commented Oct 25, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #356 (62a07b8) into bs5 (504eb59) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                bs5     #356      +/-   ##
============================================
- Coverage     99.32%   99.22%   -0.10%     
  Complexity      353      353              
============================================
  Files            21       21              
  Lines          1031     1031              
============================================
- Hits           1024     1023       -1     
- Misses            7        8       +1     
Impacted Files Coverage Δ
src/View/Helper/FormHelper.php 99.06% <ø> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664311c...62a07b8. Read the comment docs.

@ndm2
Copy link
Collaborator Author

ndm2 commented Oct 26, 2021

Coverage reduced because 4.3 is used for coverage generation, where the < 4.3 backwards compatibility workaround won't run. It is still covered by tests though.

@ndm2 ndm2 merged commit d1b31b3 into FriendsOfCake:bs5 Oct 26, 2021
@ndm2 ndm2 deleted the cakephp-4.3-compatibility branch October 26, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants