4.x - Automatically generate placeholders for floating labels. #367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
============================================
+ Coverage 99.22% 99.23% +0.01%
- Complexity 360 368 +8
============================================
Files 21 21
Lines 1027 1043 +16
============================================
+ Hits 1019 1035 +16
Misses 8 8
Continue to review full report at Codecov.
|
| * Modify options for placeholders. | ||
| * | ||
| * @param string $fieldName Field name. | ||
| * @param array $options Options. See `$options` argument of `control()` method. |
There was a problem hiding this comment.
we usually array<string, mixed> those
Same for assoc return value.
There was a problem hiding this comment.
I'd say that's something for a new PR if we want to adpot that syntax, as there's dozens of places that just use the plain array hints.
There was a problem hiding this comment.
Well, new code could already do that, the same as you just added return types :)
There was a problem hiding this comment.
The other option processing methods already have return types, I only copy pasta'd it 😉
While this will not cover custom types, it should be good enough for most scenarios, eg use of
textandtextareatypes.The text inference is copied from the core, but without support for the special
_idskey, as this would by default cause aselectinput to be generated, where placeholders do not apply.Refs #349 (comment) /cc @gerhard-lechner