Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing/incorrect form-* classes for checkbox() and select(). #373

Merged
merged 1 commit into from
May 5, 2022

Conversation

ndm2
Copy link
Collaborator

@ndm2 ndm2 commented Apr 28, 2022

fixes #369

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #373 (1be2f9e) into master (6924ce4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #373   +/-   ##
=========================================
  Coverage     99.23%   99.23%           
- Complexity      368      369    +1     
=========================================
  Files            21       21           
  Lines          1043     1046    +3     
=========================================
+ Hits           1035     1038    +3     
  Misses            8        8           
Impacted Files Coverage Δ
src/View/Helper/FormHelper.php 99.13% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6924ce4...1be2f9e. Read the comment docs.

@dereuromark dereuromark merged commit 86fc099 into FriendsOfCake:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$this->Form->select() missing "form-select" class
2 participants