Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Cake5 upgrade. #136

Merged
merged 14 commits into from
Oct 13, 2023
Merged

Init Cake5 upgrade. #136

merged 14 commits into from
Oct 13, 2023

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Jan 20, 2023

WIP

Missing still:

  • Fixtures
  • RequestHandler replacement (how?) for auto csv

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1d5ada1) 95.41% compared to head (c2e539c) 88.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x     #136      +/-   ##
============================================
- Coverage     95.41%   88.13%   -7.28%     
- Complexity       38       40       +2     
============================================
  Files             1        2       +1     
  Lines           109      118       +9     
============================================
  Hits            104      104              
- Misses            5       14       +9     
Files Coverage Δ
src/CsvViewPlugin.php 0.00% <ø> (ø)
src/View/CsvView.php 95.41% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stickler-ci
Copy link

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

phpcs.xml Show resolved Hide resolved
ADmad and others added 2 commits October 13, 2023 23:44
@ADmad ADmad merged commit 37dcf88 into 4.x Oct 13, 2023
13 of 14 checks passed
@ADmad ADmad deleted the 5.x branch October 13, 2023 18:18
@ADmad ADmad restored the 5.x branch October 13, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants