Complying to coding standards #5
Conversation
Signed-off-by: Joshua Paling <joshua.paling@gmail.com>
| if(is_numeric($key)){ | ||
| protected function _addUniquePaths($dataRow, $excludePaths, &$extract, $parentPath = '') { | ||
| foreach ($dataRow as $key => $value) { | ||
| $fullPath = ($parentPath !== '')? $parentPath . '.' . $key : $key; |
|
👍 |
| @@ -33,11 +33,11 @@ public function startup(Controller $controller) { | |||
| * @param array $excludePaths [description] | |||
| * @return array an array of Hash::extract() compatible paths | |||
There was a problem hiding this comment.
I dont think the additional spaces are needed (a single one before/after/between "return array" suffices):
@return array An array of Hash::extract() compatible paths
|
It passes the code sniffer with no errors, so presumably the issues you've mentioned are down to preference. Might fix them later. |
|
Well, there are just no "sniffs" for it yet :) Sry for being a stickler. |
|
Gotta sniff the fuck outta this
|
|
ha it's cool. Good to know for future reference. |
|
🎱 |
Complying to coding standards
|
Merged, thanks for the pull request! |
|
Alright, added phpcs to my tests. After a few goes, everything checks out on master :) |
Haven't changed anything other than complying to coding standards.
Signed-off-by: Joshua Paling joshua.paling@gmail.com