No deprecation

[Modicrumb]

I tried my best to make it deprecation free in CakePHP 3.6. As a result it's probably not BC with CakePHP versions less than 3.5. I've also updated the documentation for the new withDownload method.

[dereuromark]

Can you resolve the conflict?

[dereuromark]

Don't forget to also adjust composer then and set proper min version for the framework
3.0 sure aint true anymore.

[Modicrumb]

I've resolved the conflict, regardless, tests do not pass because I'm still using the deprecated method type() instead of withType(), because withType() does not properly replace type() for new types. Meaning I am just using type(). Deprecation errors come through due to this though. I wasn't sure if I should just file a separate issue in the cakephp github. But I would need to set up a test to make sure that I'm right about withType not handling new types like type() did.

Oh shnap. It seems tests are actually going through on some places? Maybe all I need to do is run codesniffer on this stuff and I suppose update composer?

[codecov]

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage     97.63%   97.63%           
  Complexity       55       55           
=========================================
  Files             1        1           
  Lines           127      127           
=========================================
  Hits            124      124           
  Misses            3        3

Impacted Files	Coverage Δ	Complexity Δ
src/View/CsvView.php	97.63% <ø> (ø)	55 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705d7d7...74618ed. Read the comment docs.

[Modicrumb]

I'm baffled at the Fatal error: Call to undefined method Cake\Http\Response::getType() in /home/travis/build/FriendsOfCake/cakephp-csvview/tests/TestCase/View/CsvViewTest.php on line 41

[Modicrumb]

Alright so getType is not included until 3.5.5 my bad, will fix this when I get home

[dereuromark]

I helped.
The Requirements section in README should mention 3.5.5+ then, as well.
Otherwise all good and we can release a minor here, since this is all BC then.

[Modicrumb]

Fixed up the readme.

[dereuromark]

Now we just need to fix CS.