Merge pull request #542 from FriendsOfCake/issue-541

Fix "undefined index" error.
FriendsOfCake · Jun 19, 2020 · 7f5a43c · 7f5a43c
2 parents 7cfda1b + 756c42a
commit 7f5a43c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Model/Behavior/UploadBehavior.php b/src/Model/Behavior/UploadBehavior.php
@@ -75,7 +75,9 @@ public function beforeMarshal(EventInterface $event, ArrayObject $data, ArrayObj
             if (!empty($dataArray[$field]) && $dataArray[$field]->getError() !== UPLOAD_ERR_NO_FILE) {
                 continue;
             }
-            unset($data[$field]);
+            if (isset($data[$field])) {
+                unset($data[$field]);
+            }
         }
     }
 

diff --git a/tests/TestCase/Model/Behavior/UploadBehaviorTest.php b/tests/TestCase/Model/Behavior/UploadBehaviorTest.php
@@ -182,12 +182,12 @@ public function testInitializeAddBehaviorOptionsInterfaceConfig()
     public function testBeforeMarshalOk()
     {
         $validator = $this->getMockBuilder('Cake\Validation\Validator')->getMock();
-        $validator->expects($this->once())
+        $validator->expects($this->atLeastOnce())
                   ->method('isEmptyAllowed')
                   ->will($this->returnValue(true));
 
         $table = $this->getMockBuilder('Cake\ORM\Table')->getMock();
-        $table->expects($this->once())
+        $table->expects($this->atLeastOnce())
                     ->method('getValidator')
                     ->will($this->returnValue($validator));
 
@@ -203,6 +203,10 @@ public function testBeforeMarshalOk()
         $data = new ArrayObject($this->dataOk);
         $behavior->beforeMarshal(new Event('fake.event'), $data, new ArrayObject());
         $this->assertEquals(new ArrayObject($this->dataOk), $data);
+
+        $data = new ArrayObject();
+        $behavior->beforeMarshal(new Event('fake.event'), $data, new ArrayObject());
+        $this->assertEquals(new ArrayObject([]), $data);
     }
 
     public function testBeforeMarshalError()