Merge pull request #379 from jorisvaesen/master

Fix double directory separator in constructFiles when following docs
FriendsOfCake · Mar 27, 2016 · d123726 · d123726
2 parents c298568 + 0a9f083
commit d123726
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/docs/configuration.rst b/docs/configuration.rst
@@ -19,7 +19,7 @@ passed in under each field in your behavior configuration.
     - Default: (string)
       ``Josegonzalez\Upload\File\Transformer\DefaultTransformer``
 
--  ``path``: A path relative to the ``filesystem.root``. Should end in ``{DS}``
+-  ``path``: A path relative to the ``filesystem.root``.
 
    -  Default: (string)
       ``'webroot{DS}files{DS}{model}{DS}{field}{DS}'``

diff --git a/src/Model/Behavior/UploadBehavior.php b/src/Model/Behavior/UploadBehavior.php
@@ -203,19 +203,20 @@ public function getWriter(Entity $entity, $data, $field, $settings)
      */
     public function constructFiles(Entity $entity, $data, $field, $settings, $basepath)
     {
+        $basepath = (substr($basepath, -1) == DS ? $basepath : $basepath . DS);
         $default = 'Josegonzalez\Upload\File\Transformer\DefaultTransformer';
         $transformerClass = Hash::get($settings, 'transformer', $default);
         $results = [];
         if (is_subclass_of($transformerClass, 'Josegonzalez\Upload\File\Transformer\TransformerInterface')) {
             $transformer = new $transformerClass($this->_table, $entity, $data, $field, $settings);
             $results = $transformer->transform();
             foreach ($results as $key => $value) {
-                $results[$key] = $basepath . '/' . $value;
+                $results[$key] = $basepath . $value;
             }
         } elseif (is_callable($transformerClass)) {
             $results = $transformerClass($this->_table, $entity, $data, $field, $settings);
             foreach ($results as $key => $value) {
-                $results[$key] = $basepath . '/' . $value;
+                $results[$key] = $basepath . $value;
             }
         } else {
             throw new UnexpectedValueException(sprintf(

diff --git a/tests/TestCase/Model/Behavior/UploadBehaviorTest.php b/tests/TestCase/Model/Behavior/UploadBehaviorTest.php
@@ -309,6 +309,27 @@ public function testConstructFiles()
         $this->assertEquals(['path/to/file/on/disk' => 'some/path/file.txt'], $files);
     }
 
+    public function testConstructFilesWithBasePathEndingDS()
+    {
+        $files = $this->behavior->constructFiles(
+            $this->entity,
+            ['tmp_name' => 'path/to/file/on/disk', 'name' => 'file.txt'],
+            'field',
+            [],
+            'path/'
+        );
+        $this->assertEquals(['path/to/file/on/disk' => 'path/file.txt'], $files);
+
+        $files = $this->behavior->constructFiles(
+            $this->entity,
+            ['tmp_name' => 'path/to/file/on/disk', 'name' => 'file.txt'],
+            'field',
+            [],
+            'some/path/'
+        );
+        $this->assertEquals(['path/to/file/on/disk' => 'some/path/file.txt'], $files);
+    }
+
     public function testConstructFilesWithCallable()
     {
         $callable = function () {
@@ -324,6 +345,21 @@ public function testConstructFilesWithCallable()
         $this->assertEquals(['path/to/callable/file/on/disk' => 'some/path/file.text'], $files);
     }
 
+    public function testConstructFilesWithCallableAndBasePathEndingDS()
+    {
+        $callable = function () {
+            return ['path/to/callable/file/on/disk' => 'file.text'];
+        };
+        $files = $this->behavior->constructFiles(
+            $this->entity,
+            ['tmp_name' => 'path/to/file/on/disk', 'name' => 'file.txt'],
+            'field',
+            ['transformer' => $callable],
+            'some/path/'
+        );
+        $this->assertEquals(['path/to/callable/file/on/disk' => 'some/path/file.text'], $files);
+    }
+
     public function testConstructFilesException()
     {
         $this->setExpectedException('UnexpectedValueException', "'transformer' not set to instance of TransformerInterface: UnexpectedValueException");